From 79559ba6f076c3cc9ba93fa07568971be597c52d Mon Sep 17 00:00:00 2001
From: Tyler G <tyler@atyg.org>
Date: Sat, 22 Aug 2026 22:44:44 -0700
Subject: [PATCH] fix: Restore global scope for UI functions by separating
 qa.js from inline script

---
 viewer/index.html |  6 +++---
 viewer/qa.js      | 26 ++++++++++++--------------
 2 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/viewer/index.html b/viewer/index.html
index 07d8d0e..f77dae1 100644
--- a/viewer/index.html
+++ b/viewer/index.html
@@ -922,7 +922,8 @@
     </div>
 
     <!-- Master Interactive JavaScript Application -->
-    <script type="module">
+    <script src="./qa.js"></script>
+    <script>
         let scene, camera, renderer, controls;
         let groupSkeleton, groupSheets, groupFacade, groupDrives, groupFans, groupPcba, groupIsolatedPart;
         let raycaster, mouse;
@@ -2219,8 +2220,7 @@
             renderer.render(scene, camera);
         }
 
-        import { loadQaChecklist } from './qa.js';
-
+        
         window.onload = function() {
             loadQaChecklist();
             init3D();
diff --git a/viewer/qa.js b/viewer/qa.js
index 0c59509..e941d70 100644
--- a/viewer/qa.js
+++ b/viewer/qa.js
@@ -1,5 +1,5 @@
 // QA Checklist API Client
-export async function loadQaChecklist() {
+async function loadQaChecklist() {
     try {
         const res = await fetch('/api/qa');
         if (!res.ok) throw new Error("Failed to load QA data");
@@ -8,7 +8,7 @@ export async function loadQaChecklist() {
         const container = document.getElementById('qa-checklist-container');
         if (!container) return;
         
-        container.innerHTML = ''; // Clear hardcoded items
+        container.innerHTML = '';
         
         tasks.forEach(task => {
             const div = document.createElement('div');
@@ -20,7 +20,9 @@ export async function loadQaChecklist() {
             checkbox.dataset.id = task.id;
             checkbox.addEventListener('change', async (e) => {
                 await toggleQaTask(task.id, e.target.checked);
-                updateQAProgress();
+                if (typeof updateQAProgress === 'function') {
+                    updateQAProgress();
+                }
             });
             
             const label = document.createElement('label');
@@ -31,22 +33,15 @@ export async function loadQaChecklist() {
             container.appendChild(div);
         });
         
-        // Expose function to global scope since HTML uses inline onchange="updateQAProgress()" for some reason
-        window.updateQAProgress = () => {
-            const total = document.querySelectorAll('.check-item input').length;
-            const checked = document.querySelectorAll('.check-item input:checked').length;
-            const pct = Math.round((checked / total) * 100) || 0;
-            document.getElementById('qa-progress-label').innerText = `${pct}% Complete`;
-            document.getElementById('qa-progress-bar').style.width = `${pct}%`;
-        };
-        
-        window.updateQAProgress();
+        if (typeof updateQAProgress === 'function') {
+            updateQAProgress();
+        }
     } catch (err) {
         console.error("QA Loading Error:", err);
     }
 }
 
-export async function toggleQaTask(id, is_completed) {
+async function toggleQaTask(id, is_completed) {
     try {
         await fetch(`/api/qa/${id}`, {
             method: 'PUT',
@@ -57,3 +52,6 @@ export async function toggleQaTask(id, is_completed) {
         console.error("Failed to update QA task", err);
     }
 }
+
+window.loadQaChecklist = loadQaChecklist;
+window.toggleQaTask = toggleQaTask;