From 09c2b5d7a7378e94ebc820cd351f8d348400ee7e Mon Sep 17 00:00:00 2001 From: Tyler Gillispie Date: Wed, 26 Aug 2026 12:04:49 -0700 Subject: [PATCH] docs(protocol): strip redundant pre-review summary gate from agent instructions --- tasks/GUIDELINES.md | 5 +---- tasks/do.md | 16 ++++------------ 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/tasks/GUIDELINES.md b/tasks/GUIDELINES.md index ecba4c3..5434cbb 100644 --- a/tasks/GUIDELINES.md +++ b/tasks/GUIDELINES.md @@ -97,9 +97,6 @@ subagents): 2. **Positive Final-State Delivery:** Never use negative constraints to govern tool use. Instead, formulate unambiguous terminal Acceptance Criteria (clean git tree, passing test suites, formatted code). -3. **Pre-Review Summary Gate:** Require worker agents to provide a concise - verification summary (modified files and test pass evidence) BEFORE - requesting code review or opening the PR. -4. **DRY Prompting:** Always reference repository guidelines (`AGENTS.md`, +3. **DRY Prompting:** Always reference repository guidelines (`AGENTS.md`, `tasks/GUIDELINES.md`) instead of copy-pasting operational rules into agent prompts. diff --git a/tasks/do.md b/tasks/do.md index 3acedcb..4998d34 100644 --- a/tasks/do.md +++ b/tasks/do.md @@ -46,16 +46,8 @@ and provide the following block: - Keep the task file in `tasks/new/` during execution; only move it to `tasks/complete/` upon successful verification (or park in `tasks/wip/` only if work cannot be finished in this session). - Run ONLY hermetic unit tests (`deno test --allow-all`). Do NOT start long-running servers (`deno task start` / `deno task dev`). -**Acceptance Criteria & Delivery Protocol:** - -1. **Pre-Review Quality & Summary (Before Requesting Review / Opening PR):** - - Run and pass all quality gates: `deno fmt`, `deno task lint`, `deno task check`, and `deno test --allow-all`. - - Ensure the git working tree contains only intentional modifications to target deliverables (zero untracked or temporary files). - - Present a concise verification summary detailing: - * Exact list of modified/created files - * Test execution results proving all test suites pass - -2. **Final Completion (Upon Approval):** - - Move the task file from `tasks/new/` directly to `tasks/complete/YYYY-MMDD.XX.agent.type.scope.title-HHMM.md` (or park in `tasks/wip/` only if work cannot be finished in this session). - - Submit the final pull request with a clean git history. +**Acceptance Criteria:** +- Run and pass all quality gates: `deno fmt`, `deno task lint`, `deno task check`, and `deno test --allow-all`. +- Ensure the git working tree contains only intentional modifications to target deliverables (zero untracked or temporary files). +- Move the task file from `tasks/new/` directly to `tasks/complete/YYYY-MMDD.XX.agent.type.scope.title-HHMM.md` (or park in `tasks/wip/` only if work cannot be finished in this session). ```